Skip to content

cmake problem with , instead of semi-colon in the ENVIRONMENT property for cmake tests

Hi, when I was testing the guix recipe, I found a problem with the PYTHONPATH defined in the hysop_tests.cmake file

  set_tests_properties(${test_name} PROPERTIES ENVIRONMENT "PYTHONPATH=$ENV{PYTHONPATH}:${HYSOP_BUILD_PYTHONPATH}")
  set_tests_properties(${test_name} PROPERTIES ENVIRONMENT "PYTHONPATH=$ENV{PYTHONPATH}:${HYSOP_BUILD_PYTHONPATH},LD_LIBRARY_PATH=$ENV{LD_LIBRARY_PATH}:${HYSOP_BUILD_PYTHONPATH},HYSOP_ENABLE_LONG_TESTS=${ENABLE_LONG_TESTS}")

first, I think the first line is redondant. In the second, according to there comma must be semi-colons. With this modificiation, pytest embedded in python finds the path to hysop. I did the fix in the branch fixSemiColonInEnvironvment4Test. Could someone confirm that it works, and merge it if you accept the fix Bests

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information